Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation of CMS_WCHARM_7TEV in the new format #2245

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

achiefa
Copy link
Contributor

@achiefa achiefa commented Dec 10, 2024

Comments

This dataset delivers two different observables:

  • Total x-sec
  • Ratio of x-secs

The variant sys_10 accounts for the 3pt prescription and thus it should be deprecated in the new format.

$(x,Q^2)$-map and data-theory comparison

Legacy: [default]
New: [default]

@achiefa achiefa requested a review from RoyStegeman December 10, 2024 11:43
@achiefa achiefa self-assigned this Dec 10, 2024
@achiefa achiefa marked this pull request as draft December 10, 2024 11:43
@achiefa
Copy link
Contributor Author

achiefa commented Dec 10, 2024

This PR is still WIP. Here you can find a report of the new implementation, which is preliminary: report
I have some comments:

  • The RATIO xsec in HepData provides statistical and systematic uncertainties. However, the legacy version implemented only the statistical uncertainty (I'm not considering the two additional sys uncertainties for the scale variations). Is there something here that I don't understand?
  • For the TOT xsec, I can't reconstruct the covmat. Note that, for this observable, we have the correlation matrix.

@achiefa achiefa force-pushed the new_CMS_WCHARM_7TEV_WPWM branch from e4bf77e to 6a5cbb0 Compare December 13, 2024 09:50
@achiefa
Copy link
Contributor Author

achiefa commented Dec 13, 2024

I have finalised the implementation of this dataset. Besides the new report posted in the description of this PR, I have the following comments:

  • For the TOT observable, the covariance matrix is applied to the systematic uncertainties and not to the statistical uncertainties, as I mistakenly did before.
  • For the TOT observable, I didn't manage to reproduce the t0 matrix of the legacy implementation. I suspect the data in HepData have changed since the first implementation of this dataset. This is indeed the case for the RATIO observable, for which the statistical uncertainties in HepData differ from the statistical uncertainties reported in the legacy file.
  • For the RATIO observable, I didn't manage to reproduce the legacy t0 matrix either. The reason is the one explained above. Moreover, the HepData provides an additional systematic uncertainty that the legacy implementation does not have.
  • In terms of data-theory comparison, the plots look really similar between the new and the legacy implementations. The major difference is in the uncertainty bars, as expected for the reasons above. The chi2's for the RATIO is slightly better: 2.45 (new) VS 2.49 (legacy). For the TOT observable, the chi2 worsens in the new implementation: 1.72 (new) VS 0.96 (legacy). However, this is expected, given the discussion above.

Please, @RoyStegeman have a look at the implementation and let me know if you find something unclear or wrong.

@achiefa achiefa force-pushed the new_CMS_WCHARM_7TEV_WPWM branch from 2ee81ed to 5bc8d02 Compare December 13, 2024 11:00
@achiefa achiefa marked this pull request as ready for review December 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant